Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crashes module to SPM Manifest #2048

Merged
merged 4 commits into from
May 6, 2020

Conversation

russelarms
Copy link
Contributor

@russelarms russelarms commented May 5, 2020

Things to consider before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you check UI tests on the sample app? They are not executed on CI.
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Add Crashes module to SPM Manifest.

Related PRs or issues

AB#79697

Misc

TODO: we need to replace .branch("feature/spm") once PLCR is ready.

@russelarms russelarms marked this pull request as ready for review May 5, 2020 13:15
CHANGELOG.md Outdated Show resolved Hide resolved
@MatkovIvan MatkovIvan merged commit 599d0a1 into feature/SPM-support May 6, 2020
@MatkovIvan MatkovIvan deleted the feature/spm-crashes branch May 6, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants