This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: return more verbose error during new creation for display in the client #5880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
reviewed
Feb 24, 2021
| const result = BackgroundProcessManager.getProcessStatus(jobId); | ||
| if (result) { | ||
| res.status(result.httpStatusCode).json(result); | ||
| res.status(result.httpStatusCode).json({ |
Contributor
There was a problem hiding this comment.
are we ok with sending the additional properties httpStatusCode and latestMessage in addition to the statusCode and message. Feels like the response will have duplicate fields for status code and message.
Contributor
Author
There was a problem hiding this comment.
I think that's ok -- the client is looking for statusCode and message only in order to display them in the UI. No harm in leaving the other fields in there as there other fields in that object as well that are used at times in the UI such as the history and log output of the background process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR exposes the error message from inside background build processes to the client for display.
Task Item
fixes #5783