This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: error message specificity, tempalteID state management, runtime selection data handling #5851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e due to template ids with '@microsoft/' strings
pavolum
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
Contributor
Author
|
TODO: handle strong typing of runtime selection (azureWebApp and azureFunction), currently it is just passing the string from the front end, to the server, to the yeomen generators |
pavolum
changed the title
benbrown
reviewed
Feb 22, 2021
benbrown
reviewed
Feb 22, 2021
benbrown
reviewed
Feb 22, 2021
| const handleCreateNext = async () => { | ||
| setCreationFlowStatus(CreationFlowStatus.NEW_FROM_TEMPLATE); | ||
| navigate(`./create/${data}`); | ||
| navigate(`./create/template`); |
Contributor
There was a problem hiding this comment.
I wonder if some of this could have been avoided by doing an encodeURIcomponent on the name value...
Contributor
There was a problem hiding this comment.
I confirmed this was the case.
Contributor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various small items for the new creation experience are handled in this PR. More details outline in each task item below
Task Item