This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: resolve potential crashing bug when npm is not installed #5963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d fails around missing npm[
…rror with more information.
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
approved these changes
Feb 25, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…oft#5963) * return the error message for a status * move yeoman init where it is called instead of in constructor to avoid fails around missing npm[ * correct path for .yo-repository folder * Catch problems with yeoman env regarding npm and throw a customized error with more information. * update text of message
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we were creating a yeoman-environment object in a constructor, which caused the app to crash if npm is not installed.
This change moves the yeoman-evironment calls to the create methods, so the error should not crash the app during startup.
Includes #5880
Task Item
Fixes #5951