This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: enable new creation flow as default #5881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbrown
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
previously requested changes
Feb 25, 2021
beyackle
approved these changes
Apr 6, 2021
boydc2014
approved these changes
Apr 6, 2021
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* plumb through the option to select azure functions scaffolding * update test * fix some tests * Removing unused var * adding back package json precommit declaration * fixing errors that happened in merge * fix import statement * js support * fix: revert yeoman-environment to 2.10.3 from 3.1.0 * initial commit of js runtime support with some draft URLs * fis: change feature flag text * mostly working js publish * - Passing runtime choice down to generator - Passing runtime language down to generaotr - Prepping merge with js runtime branch * Passing of runtime type and language to generators from UI implemented * Adding testing dropdown to more easily test templates * removing npm build as it is unneeded for js generators * removing unneeeded code for npm build on buildDeploy * Adding runtime template for dotnet functions and node functions * Adding needed fields to botTemplate obj * Fixing keyword parsing and rendering logic for templates * Removing runtime language dropdown from UI * adding logic for correct template specific runtime types as available selections in UI * - Removing unused options code - Setting deafult template to top of list, removing hardcoding of default template * Enhancing template search query * remove unneeded console logs * Fixing errors after merge * cleanup some text, remove unneeded fields * update feed * fix issue where required items were included twice * remove comment * update and cleanup * update variable * fix dismiss of handoff * fix tests, update package manager bf-dialgo to latest dev * fix tests, adjust labels * remove feature flag * fix tests * remove unused elements * restore support for legacy runtimes * Adding mocked dipsatch function to fix broken UT * Fixing unit test * Making PR changes. - simplyfying array check logic - removing unneeded null check * Fixing include statements * Fixing default naming * Fixing home page integration test * Fixing creation UT * Removing old creation integration test * Adding integration test for new bot creation * Fixing navigateUrl integration test * Changing names * Removing unused dep * Fixing dependency * increasing wait time for creation integration test * Testin CI failures with different wait times * Update azure-pipelines.yml for Azure Pipelines * Indent update * Change to 3.1.x * Temp removal of expando to get error from CI machine * testing name change * Getting more error info in modal for testing * fix bad merge * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Update azure-pipelines.yml for Azure Pipelines * Finalizing dotnet install and nuget feed config step in pipeline * Reverting error modal testing changes * Removing FF check * Removing unused import Co-authored-by: Andy Brown <asbrown002@gmail.com> Co-authored-by: Patrick Volum <pavolum@microsoft.com> Co-authored-by: pavolum <pavolum@outlook.com> Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Ben Yackley <61990921+beyackle@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This includes the functionality necessary for creating and using the new Adaptive Runtime in Javascript, and Azure Functions functionality in both Javascript and Dotnet.
In addition, this makes the "new create flow" the default and ONLY way to create new bots. This removes the "new creation flow" feature flag and enables all features previously hidden.
Task Item
fixes #5556
fixes #6416