Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Jan 29, 2021

Description

Our current lg CRUD operations are sync across multiple locales, to keep them structure aligns. but if the bot loaded initial status is not structure align (e.g migration from old version, edited in third party editor), authoring in Composer will meet a error, and so does running the bot.

For example a bot have two locale lg files:

<!-- a.en-us.lg -->                  |              <!-- a.zh-cn.lg --> 
# SendActivity_12345                 |
-hi                                  |

The searching scope of dialog used but missing templates can be .<*locale>.lg. for example

And dialog 'a' is using a lg called 'SendActivity_12345' , will do auto add to lg files missing this template ( here is zh-cn, same to other locales fr-fr etc.).

After auto repair, two locale lg files will looks like:

<!-- a.en-us.lg -->                  |              <!-- a.zh-cn.lg --> 
# SendActivity_12345                 |              # SendActivity_12345
-hi                                  |              -

Task Item

refs #5441

Screenshots

Real-time refreshing "readOnly" editor:

preview

@coveralls
Copy link

coveralls commented Jan 29, 2021

Coverage Status

Coverage increased (+0.03%) to 55.192% when pulling b853627 on zhixzhan/lg-multilang-files-sync into 7bafd30 on main.

@boydc2014 boydc2014 merged commit 4de92c4 into main Feb 2, 2021
@boydc2014 boydc2014 deleted the zhixzhan/lg-multilang-files-sync branch February 2, 2021 10:31
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
)

* compare and drop entry file changes, keep related changes commit

* Auto create placeholder template used in dialog

* clean up

* update tests

* sync name change edting in all up view

* readOnly editor should take external value change

* lint

Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com>
Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants