This repository was archived by the owner on Jul 9, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 374
fix: lg files auto add placeholder for missing templates #5654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinaath
reviewed
Jan 30, 2021
boydc2014
approved these changes
Feb 2, 2021
Closed
8 tasks
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
) * compare and drop entry file changes, keep related changes commit * Auto create placeholder template used in dialog * clean up * update tests * sync name change edting in all up view * readOnly editor should take external value change * lint Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our current lg CRUD operations are sync across multiple locales, to keep them structure aligns. but if the bot loaded initial status is not structure align (e.g migration from old version, edited in third party editor), authoring in Composer will meet a error, and so does running the bot.
For example a bot have two locale lg files:
The searching scope of dialog used but missing templates can be .<*locale>.lg. for example
And dialog 'a' is using a lg called 'SendActivity_12345' , will do auto add to lg files missing this template ( here is zh-cn, same to other locales fr-fr etc.).
After auto repair, two locale lg files will looks like:
Task Item
refs #5441
Screenshots
Real-time refreshing "readOnly" editor: