Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@zhixzhan
Copy link
Contributor

@zhixzhan zhixzhan commented Feb 18, 2021

Description

In #5654 lg files auto add placeholder for missing templates, load bot will search <dialogId>.lg find missing lg and do add. but did not search imports, this fix expand the search grid to all imported files.

Task Item

close #5763
close #5724

Screenshots

@coveralls
Copy link

coveralls commented Feb 18, 2021

Coverage Status

Coverage decreased (-0.003%) to 54.16% when pulling c7c3548 on zhixzhan/lg-formdialog-fix into 93f12c9 on main.

@boydc2014
Copy link
Contributor

Please fix the UT, and i have one question that, the orignal issue seems to be, we are "over" copying, and your fix seems to be, copying more? Can you explain a little bit more, why the previous behavior is affecting form dialog, and how your fix would fix it?

@zhixzhan
Copy link
Contributor Author

Please fix the UT, and i have one question that, the orignal issue seems to be, we are "over" copying, and your fix seems to be, copying more? Can you explain a little bit more, why the previous behavior is affecting form dialog, and how your fix would fix it?

Actually not copy, it is adding LG templates used in dialog, but missing in <dialogId>.lg. In form dialog case, generated lg templates is all in child imported lg files, so it added lots of empty lg templates in <dialogId>.lg.

@boydc2014
Copy link
Contributor

Please fix the UT, and i have one question that, the orignal issue seems to be, we are "over" copying, and your fix seems to be, copying more? Can you explain a little bit more, why the previous behavior is affecting form dialog, and how your fix would fix it?

Actually not copy, it is adding LG templates used in dialog, but missing in <dialogId>.lg. In form dialog case, generated lg templates is all in child imported lg files, so it added lots of empty lg templates in <dialogId>.lg.

get it

@boydc2014 boydc2014 merged commit 1ff86ef into main Feb 18, 2021
@boydc2014 boydc2014 deleted the zhixzhan/lg-formdialog-fix branch February 18, 2021 15:01
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* search imports

* update test

Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

4 participants