This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: validate dialog take a long time when updating lg in form #5483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
Contributor
|
Looks good, this should be the last piece to include for a patch release. |
hatpick
reviewed
Jan 11, 2021
srinaath
reviewed
Jan 11, 2021
Contributor
Author
Composer/packages/client/src/recoilModel/dispatchers/project.ts
Outdated
Show resolved
Hide resolved
boydc2014
approved these changes
Jan 13, 2021
zhixzhan
reviewed
Jan 29, 2021
|
|
||
| updateLgFiles(callbackHelpers, projectId, { updates: updatedFiles }, (current, changed) => { | ||
| // compare to drop expired content already setted above. | ||
| return current?.content === changed?.content; |
Contributor
There was a problem hiding this comment.
This line break multilang file sync, We need also compare id, because "updateFiles" can be other lg file, and the content is always different , then will always drop their changes. Fixed this in #5654
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…soft#5483) * async selector * update lg files state * update the luProvider for dialog * fix unit test * add cache for dialog validate * fix lint * fix comments * fix tests * fix lint * update text * fix lint * fix lint Co-authored-by: Srinaath Ravichandran <srinaath27@gmail.com> Co-authored-by: Dong Lei <donglei@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Root cause
The lg file update will trigger the validation function for all dialogs. A single dialog will take about 15ms, and if we have 10 dialogs in one bot, the validate time maybe 150ms.
Fix
Task Item
#minor
Screenshots
Main branch:
This PR
