This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: unify display name function in client, visual editor #5474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanlong9278
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath,
tonyanziano and
yeze322
as code owners
alanlong9278
changed the title
alanlong9278
changed the title
yeze322
reviewed
Jan 11, 2021
.../packages/adaptive-flow/src/adaptive-flow-renderer/widgets/TriggerSummary/TriggerSummary.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Looks good to extract a new shared function |
beyackle
previously requested changes
Jan 11, 2021
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
Looks mostly good - just one change I'd like to see.
beyackle
reviewed
Jan 13, 2021
yeze322
previously approved these changes
Jan 21, 2021
yeze322
dismissed
beyackle’s stale review
Code updated. Alan used a constant to check the pattern.
a-b-r-o-w-n
reviewed
Jan 21, 2021
Composer/packages/client/src/pages/design/VisualEditorHeader.tsx
Outdated
Show resolved
Hide resolved
Composer/packages/client/src/pages/design/VisualEditorHeader.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
refs #5427 |
yeze322
reviewed
Jan 29, 2021
Composer/packages/client/src/pages/design/VisualEditorHeader.tsx
Outdated
Show resolved
Hide resolved
yeze322
reviewed
Jan 29, 2021
Composer/packages/client/src/pages/design/VisualEditorHeader.tsx
Outdated
Show resolved
Hide resolved
yeze322
suggested changes
Jan 29, 2021
Contributor
yeze322
left a comment
yeze322
left a comment
There was a problem hiding this comment.
Generally good, left two comments.
* main: refactor: break down the design page(the first step) (microsoft#5623) fix: use directVersionPublish for LUIS to avoid 404 in bot response (microsoft#5639) fix: botProject UT depends on external service (microsoft#5656)
yeze322
approved these changes
Feb 1, 2021
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…5474) * unify display name function in client, visual editor * dialog displayName from $designer.name * lint * use getFriendlyName * unify manager type in design page * refactor type enums * conflict * specs failed * spcs * refactor code * refactor Co-authored-by: zhixzhan <[email protected]> Co-authored-by: zeye <[email protected]> Co-authored-by: Lu Han <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bugfix: dialog name & trigger name mismatch in left menu, breadcumbs & editors.
solution
getFriedlyNamein client & editors, Shared the function inbfc/sharedmodule.designer.nameinstead of dialog file name for dialog displayName in left menu @zhixzhan(if update name in property editor, for perf consideration, project tree won't real-time refresh )
Task Item
closes #5383
Screenshots