This repository was archived by the owner on Jul 9, 2025. It is now read-only.
refactor: break down the design page(the first step) #5623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
lei9444
changed the title
srinaath
reviewed
Jan 28, 2021
srinaath
reviewed
Jan 28, 2021
lei9444
changed the title
hatpick
suggested changes
Jan 28, 2021
Contributor
Author
|
Thanks @GeoffCoxMSFT @srinaath @hatpick |
Contributor
|
I think it makes sense to get this PR in early. The more we delay more workstreams are going to refactor their code furthur later. |
hatpick
previously approved these changes
Jan 29, 2021
srinaath
approved these changes
Jan 30, 2021
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Feb 1, 2021
* main: refactor: break down the design page(the first step) (microsoft#5623) fix: use directVersionPublish for LUIS to avoid 404 in bot response (microsoft#5639) fix: botProject UT depends on external service (microsoft#5656)
Closed
3 tasks
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* perf: split the design page * fix confilcts * fix some comments * fix lint * fix e2e test * refine the four parts * remove unused import * fix dialogid is empty * fix e2e test Co-authored-by: Srinaath Ravichandran <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR
This is the first step to break down the design page. This PR just split the design page to four parts, but the states in every component is not optimal.
Create this PR to avoid too many conflicts
Next step
Optimize every component and states
Task Item
refs #5559
Screenshots