This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: botProject UT depends on external service #5656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lei9444
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
boydc2014
approved these changes
Jan 29, 2021
boydc2014
changed the title
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Feb 1, 2021
* main: refactor: break down the design page(the first step) (microsoft#5623) fix: use directVersionPublish for LUIS to avoid 404 in bot response (microsoft#5639) fix: botProject UT depends on external service (microsoft#5656)
lei9444
added a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The outside service may be not stable, when we call it in unit tests, it may cause time out or access deny error.
In this PR
mock the luBuild and qnaBuild functions to avoid call outside service
Task Item
closes #5646
Screenshots