This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: Await until delete action finishes #4792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
a-b-r-o-w-n,
boydc2014,
cwhitten and
yeze322
as code owners
srinaath
changed the title
added 4 commits
November 12, 2020 12:55
…oser into bugfix/4791-cut-action
…/BotFramework-Composer into bugfix/4791-cut-action
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
srinaath
requested review from
GeoffCoxMSFT,
beyackle,
hatpick and
tonyanziano
as code owners
Signed-off-by: Srinaath Ravichandran <[email protected]>
a-b-r-o-w-n
approved these changes
Nov 12, 2020
Merged
Merged
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 18, 2020
* feature/bot-projects: fix: keep highlight on item with the menu open (microsoft#4835) All tests passed chore: Pull form dialogs feature branch back to main (microsoft#4841) X-platform fix for electron-server "start" script (microsoft#4833) build: add option to force rebuild of extensions (microsoft#4830) fix: remove checkURL call from navTo on dialog clicks (microsoft#4795) fix: export to zip (microsoft#4820) fix: prevent minification of AbortSignal (microsoft#4829) feat: Settings page (microsoft#4456) feat: bot projects skill & context menu (microsoft#4492) fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807) Removed some extraneous characters from the downloaded pva zip name (microsoft#4808) fix: Fixes linux icons on the taskbar (microsoft#4806) Update 1.2.0.md release: 1.2.0 (microsoft#4796) fix: validate bot name when passed via URL params (microsoft#4712) fix async move (microsoft#4799) fix: Await until delete action finishes (microsoft#4792) fix: update debounced update handlers (microsoft#4790)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* Await until delete action finishes Signed-off-by: Srinaath Ravichandran <[email protected]> * Boost coverage Signed-off-by: Srinaath Ravichandran <[email protected]> * More tests for getting coverage up Signed-off-by: Srinaath Ravichandran <[email protected]> * More tests Signed-off-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Srinaath Ravichandran <[email protected]> Co-authored-by: Andy Brown <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the Cut action.
Fixes #4792