This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: validate bot name when passed via URL params #4712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add server as project reference so that it will rebuild when building electron
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
hatpick
reviewed
Nov 9, 2020
hatpick
previously approved these changes
Nov 9, 2020
Contributor
hatpick
left a comment
hatpick
left a comment
There was a problem hiding this comment.
Changes look fine to me, but here's my overall "nit" suggestion to consider :)
I suggest breaking this PR into two PRs, one that has electron-related changes, and one have the validation changes. This helps with reverting changes easier and keeping track of them if things go south.
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 18, 2020
* feature/bot-projects: fix: keep highlight on item with the menu open (microsoft#4835) All tests passed chore: Pull form dialogs feature branch back to main (microsoft#4841) X-platform fix for electron-server "start" script (microsoft#4833) build: add option to force rebuild of extensions (microsoft#4830) fix: remove checkURL call from navTo on dialog clicks (microsoft#4795) fix: export to zip (microsoft#4820) fix: prevent minification of AbortSignal (microsoft#4829) feat: Settings page (microsoft#4456) feat: bot projects skill & context menu (microsoft#4492) fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807) Removed some extraneous characters from the downloaded pva zip name (microsoft#4808) fix: Fixes linux icons on the taskbar (microsoft#4806) Update 1.2.0.md release: 1.2.0 (microsoft#4796) fix: validate bot name when passed via URL params (microsoft#4712) fix async move (microsoft#4799) fix: Await until delete action finishes (microsoft#4792) fix: update debounced update handlers (microsoft#4790)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* update lockfile * add prelaunch task to build electron * clean up electron start scripts add server as project reference so that it will rebuild when building electron * ignore tsbuildinfo files * update extension lockfiles * add start:electron and make default start electron * validate new bot form when storage changes * add start:dev:electron script * revert changes to server tsconfig * wait on client dev server before starting electron * revert ts project changes * add server build and client ping dependencies to electron task Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Tony Anziano <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validates name when passed via URL query string.
Also adds some QOL improvements to electron development.
Task Item
fixes #4441