This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: bot projects skill & context menu #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-project-file
Signed-off-by: Srinaath Ravichandran <[email protected]> Loading multiple projects working effeiciently Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]> creat new bot Signed-off-by: Srinaath Ravichandran <[email protected]> Bot project file Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/bot-project-file Signed-off-by: Srinaath Ravichandran <[email protected]> # Conflicts: # Composer/packages/server/src/controllers/project.ts
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser-1 into srravich/bot-project-file
…oser into srravich/bot-projects-schema
creation, adding remote/local skills. Populate state management with rootbot and skills
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/botproject-file-handler Signed-off-by: Srinaath Ravichandran <[email protected]> # Conflicts: # Composer/packages/client/__tests__/components/appSettings.test.tsx
Signed-off-by: Srinaath Ravichandran <[email protected]>
This reverts commit 9aa46ca.
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…/microsoft/BotFramework-Composer into srravich/botproject-file-handler
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]> More updates Signed-off-by: Srinaath Ravichandran <[email protected]> Revert publish console logs Signed-off-by: Srinaath Ravichandran <[email protected]> All unit tests added Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…oser into srravich/botproject-file-handler
…soft/BotFramework-Composer into zhixzhan/botprojects-skill
Signed-off-by: Srinaath Ravichandran <[email protected]>
Signed-off-by: Srinaath Ravichandran <[email protected]>
…soft/BotFramework-Composer into zhixzhan/botprojects-skill
Signed-off-by: Srinaath Ravichandran <[email protected]>
beyackle
approved these changes
Nov 13, 2020
Contributor
beyackle
left a comment
beyackle
left a comment
There was a problem hiding this comment.
Looks good enough to me.
Comment on lines
+298
to
+302
| {warnings.length ? ( | ||
| <TooltipHost content={warningHTML} directionalHint={DirectionalHint.bottomLeftEdge}> | ||
| <Icon iconName={'WarningSolid'} style={warningIcon} /> | ||
| </TooltipHost> | ||
| )} | ||
| {item.warningContent && ( | ||
| <TooltipHost content={item.warningContent} directionalHint={DirectionalHint.bottomLeftEdge}> | ||
| ) : undefined} |
Contributor
There was a problem hiding this comment.
I'd go with something like warnings.length > 0 && ( <stuff here> ) - it's easier to follow.
| {item.warningContent && ( | ||
| <TooltipHost content={item.warningContent} directionalHint={DirectionalHint.bottomLeftEdge}> | ||
| ) : undefined} | ||
| {errors.length ? ( |
srinaath
approved these changes
Nov 13, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Nov 18, 2020
* feature/bot-projects: fix: keep highlight on item with the menu open (microsoft#4835) All tests passed chore: Pull form dialogs feature branch back to main (microsoft#4841) X-platform fix for electron-server "start" script (microsoft#4833) build: add option to force rebuild of extensions (microsoft#4830) fix: remove checkURL call from navTo on dialog clicks (microsoft#4795) fix: export to zip (microsoft#4820) fix: prevent minification of AbortSignal (microsoft#4829) feat: Settings page (microsoft#4456) feat: bot projects skill & context menu (microsoft#4492) fix: repair E2E tests that depended on seeing a single bot name (microsoft#4807) Removed some extraneous characters from the downloaded pva zip name (microsoft#4808) fix: Fixes linux icons on the taskbar (microsoft#4806) Update 1.2.0.md release: 1.2.0 (microsoft#4796) fix: validate bot name when passed via URL params (microsoft#4712) fix async move (microsoft#4799) fix: Await until delete action finishes (microsoft#4792) fix: update debounced update handlers (microsoft#4790)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Target on botprojects feature branch.
Task Item
close #3958
close #3954
Screenshots
Add/Remove a new remote/local skill to a bot project
Open a local skill
Create a skill
Repair broken skill
Remote skill manifest in property editor
Context menu in Project tree
