This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: fix loading of extensions by removing sample-ui-plugin #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-b-r-o-w-n
requested review from
GeoffCoxMSFT,
beyackle,
boydc2014,
cwhitten,
hatpick and
srinaath
as code owners
beyackle
previously approved these changes
Sep 23, 2020
beyackle
approved these changes
Sep 23, 2020
tonyanziano
reviewed
Sep 23, 2020
| const extensionInstallPath = path.dirname(fullPath); | ||
| const packageJson = (await readJson(fullPath)) as PackageJSON; | ||
| const isEnabled = packageJson?.composer && packageJson.composer.enabled !== false; | ||
| const metadata = getExtensionMetadata(extensionInstallPath, packageJson); |
Contributor
There was a problem hiding this comment.
why was this moved out of the if statement if the else if does not contain any reference to metadata?
Contributor
Author
There was a problem hiding this comment.
Good question. I had a version where I was just disabling the extension but setting the other metadata fields. I felt like removing the extension is better but forgot to move this back.
Contributor
There was a problem hiding this comment.
we can just move it back on some other PR
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 28, 2020
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: update l10n file (#4247) fix: fix loading of extensions by removing sample-ui-plugin (#4251) fix: split qna resource to another template (#4212) feat: UI Schema - Recognizer (#4135) fix: Change http to https for petstore.swagger.io calls (#4238) feat: install remote extensions from npm (#4224) fix: refactored select skill ui-plugin (#4207) feat: Added fieldSets to UIOptions (#4231) fix: New LG template not sync to other locale files (#4230)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
…t#4251) * fix loading of extensions by removing sample-ui-plugin * remove builtin extension from manifest if not enabled
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #4224, the way builtin plugins are loaded changed which breaks when the
extensions.jsonfile already existed, due to a failure to load thesample-ui-plugin. This just removes that from the manifest.Task Item
#minor