Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@a-b-r-o-w-n
Copy link
Contributor

Description

Adds apis to install/uninstall extensions from npm.

Includes other various refactors as well.

Task Item

closes #3992

tonyanziano
tonyanziano previously approved these changes Sep 22, 2020
Copy link
Contributor

@tonyanziano tonyanziano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

tonyanziano
tonyanziano previously approved these changes Sep 22, 2020
@coveralls
Copy link

coveralls commented Sep 22, 2020

Coverage Status

Coverage increased (+0.09%) to 55.605% when pulling ac10396 on abrown/extensions/install-from-npm into def9f80 on main.

@a-b-r-o-w-n a-b-r-o-w-n changed the title feat: install remote extensions from npm [HOLD] feat: install remote extensions from npm Sep 22, 2020
@a-b-r-o-w-n a-b-r-o-w-n changed the title [HOLD] feat: install remote extensions from npm feat: install remote extensions from npm Sep 23, 2020
@a-b-r-o-w-n a-b-r-o-w-n merged commit d361ddb into main Sep 23, 2020
@a-b-r-o-w-n a-b-r-o-w-n deleted the abrown/extensions/install-from-npm branch September 23, 2020 00:41
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 28, 2020
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
benbrown pushed a commit to benbrown/BotFramework-Composer that referenced this pull request May 24, 2021
* main:
  fix: update l10n file (microsoft#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251)
  fix: split qna resource to another template (microsoft#4212)
  feat: UI Schema - Recognizer (microsoft#4135)
  fix: Change http to https for petstore.swagger.io calls (microsoft#4238)
  feat: install remote extensions from npm (microsoft#4224)
  fix: refactored select skill ui-plugin (microsoft#4207)
  feat: Added fieldSets to UIOptions (microsoft#4231)
  fix: New LG template not sync to other locale files (microsoft#4230)
benbrown pushed a commit that referenced this pull request Jun 11, 2021
* main:
  fix: update l10n file (#4247)
  fix: fix loading of extensions by removing sample-ui-plugin (#4251)
  fix: split qna resource to another template (#4212)
  feat: UI Schema - Recognizer (#4135)
  fix: Change http to https for petstore.swagger.io calls (#4238)
  feat: install remote extensions from npm (#4224)
  fix: refactored select skill ui-plugin (#4207)
  feat: Added fieldSets to UIOptions (#4231)
  fix: New LG template not sync to other locale files (#4230)
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* move server tests into local __tests__ directories

* add tests for extensions controller

* set up jest for extension package

* add build config

* add test for manifest store

* change logger prefix

* extract npm command to helper util

* add missing dependency

* rename env variables

* use different manifest for tests

* rename parameter for clarity

* load all extensions on server start

* more name refactoring

* fix test mocks

* set up tests better

* load all extensions on server start

* refactor npm signature

* further scope npm search keywords

* apply code review feedback

* disable format message warnings for test

* reduce console noise in tests

* make console override safer

* load plugins from correct directory in test

Co-authored-by: Tony Anziano <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Users can install and uninstall extensions from npm

4 participants