This repository was archived by the owner on Jul 9, 2025. It is now read-only.
feat: Added fieldSets to UIOptions #4231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdurnford
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
beyackle,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
a-b-r-o-w-n
previously approved these changes
Sep 22, 2020
Contributor
a-b-r-o-w-n
left a comment
a-b-r-o-w-n
left a comment
There was a problem hiding this comment.
This is great! Can you update the ui schema json schema in the botframework-sdk repo?
Composer/packages/adaptive-form/src/components/fields/__tests__/FieldSets.test.tsx
Outdated
Show resolved
Hide resolved
a-b-r-o-w-n
approved these changes
Sep 22, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 28, 2020
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
Merged
benbrown
pushed a commit
to benbrown/BotFramework-Composer
that referenced
this pull request
May 24, 2021
* main: fix: update l10n file (microsoft#4247) fix: fix loading of extensions by removing sample-ui-plugin (microsoft#4251) fix: split qna resource to another template (microsoft#4212) feat: UI Schema - Recognizer (microsoft#4135) fix: Change http to https for petstore.swagger.io calls (microsoft#4238) feat: install remote extensions from npm (microsoft#4224) fix: refactored select skill ui-plugin (microsoft#4207) feat: Added fieldSets to UIOptions (microsoft#4231) fix: New LG template not sync to other locale files (microsoft#4230)
benbrown
pushed a commit
that referenced
this pull request
Jun 11, 2021
* main: fix: update l10n file (#4247) fix: fix loading of extensions by removing sample-ui-plugin (#4251) fix: split qna resource to another template (#4212) feat: UI Schema - Recognizer (#4135) fix: Change http to https for petstore.swagger.io calls (#4238) feat: install remote extensions from npm (#4224) fix: refactored select skill ui-plugin (#4207) feat: Added fieldSets to UIOptions (#4231) fix: New LG template not sync to other locale files (#4230)
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
* feat: Added fieldSets to UIOptions * fix tests * fixed test description
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
fieldSetsto the UIOptions.fieldSetsis an array ofFieldSetobjects that have propertiestitle,fields, anddefaultExpanded.titleis a required field whilefieldsanddefaultExpandedare optional. Iffieldsisundefined, it defaults to an array with a wildcard -['*']. EachfieldSetcan only have one wild card and fields cannot be used multiple times.defaultExpandeddefaults to falsy. WhendefaultExpandedis truthy, the collapsible group is expanded; otherwise, it is collapsed.In a future PR, I plan to add another UIOption -
pivotFieldSet- to support the tabbed view used in the prompts property editor. I would have included that work in this PR; however, UIOptions needs to supportadditionalFieldsbefore we can migrate the prompts tofieldSetsbecause the prompts ui-plugin currently adds a field to support LU.Task Item
refs #3588
Screenshots