This repository was archived by the owner on Jul 9, 2025. It is now read-only.
fix: sync locale files and add missing "example" string #4138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyackle
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
boydc2014,
cwhitten,
hatpick,
srinaath and
tonyanziano
as code owners
srinaath
approved these changes
Sep 15, 2020
alanlong9278
added a commit
to alanlong9278/BotFramework-Composer
that referenced
this pull request
Sep 16, 2020
* main: fix: add more missing formatMessage calls (microsoft#4144) feat: electron splash screen (microsoft#4119) feat: Add QnA files to dispatch model in skill manifest (microsoft#3985) fix: check whether operation is under current project folder (microsoft#4078) update localization and add missing "example" string (microsoft#4138) fix: defense invocation of `value.match()` (microsoft#4110) fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112) chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035) build: fix docker builds in ACR (microsoft#3986) fix: security: downgrade node-forge to 0.9.0 (microsoft#4133) chore: update archiver to fix security warning (microsoft#4116)
Merged
lei9444
pushed a commit
to lei9444/BotFramework-Composer-1
that referenced
this pull request
Jun 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the locale files to match the new strings found in the code. Adding the localization tool to "yarn build" was intended to make this process happen automatically, but it's still possible for a change to merge without that script being run first, leading to locale files being out of sync.
This also picks up one more string that got missed.
Task Item
closes #4134