Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Conversation

@a-b-r-o-w-n
Copy link
Contributor

@a-b-r-o-w-n a-b-r-o-w-n commented Sep 14, 2020

Description

Updates archiver to get security fix in bl dependency.

Task Item

#minor

@a-b-r-o-w-n
Copy link
Contributor Author

I've tested the code paths that use archiver on Mac and it works. Can I get someone with Windows to test these scenarios?

  • export to zip
  • local publish (start bot)
  • publish to azure

@coveralls
Copy link

coveralls commented Sep 14, 2020

Coverage Status

Coverage remained the same at 55.5% when pulling 6550a5b on abrown/fix/security-issue into 70f12ea on main.

@a-b-r-o-w-n a-b-r-o-w-n changed the title security: update archiver to fix security warning chore: update archiver to fix security warning Sep 14, 2020
@boydc2014
Copy link
Contributor

@VanyLaw can you help test in windows for the above flow?

@VanyLaw
Copy link
Contributor

VanyLaw commented Sep 15, 2020

Sure, I will test it

@VanyLaw
Copy link
Contributor

VanyLaw commented Sep 15, 2020

@a-b-r-o-w-n I tested it on windows with echobot, all can pass.

@boydc2014 boydc2014 merged commit 98efa7f into main Sep 15, 2020
@boydc2014 boydc2014 deleted the abrown/fix/security-issue branch September 15, 2020 10:10
alanlong9278 added a commit to alanlong9278/BotFramework-Composer that referenced this pull request Sep 16, 2020
* main:
  fix: add more missing formatMessage calls (microsoft#4144)
  feat: electron splash screen (microsoft#4119)
  feat: Add QnA files to dispatch model in skill manifest (microsoft#3985)
  fix: check whether operation is under current project folder (microsoft#4078)
  update localization and add missing "example" string (microsoft#4138)
  fix: defense invocation of `value.match()` (microsoft#4110)
  fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112)
  chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035)
  build: fix docker builds in ACR (microsoft#3986)
  fix: security: downgrade node-forge to 0.9.0 (microsoft#4133)
  chore: update archiver to fix security warning (microsoft#4116)
@cwhitten cwhitten mentioned this pull request Nov 13, 2020
lei9444 pushed a commit to lei9444/BotFramework-Composer-1 that referenced this pull request Jun 15, 2021
* update archiver to fix security warning

* remove package-lock from server directory

Co-authored-by: Dong Lei <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants