feat: electron splash screen #4119
Conversation
…oser into sorgh/splash_screen
hatpick
requested review from
GeoffCoxMSFT,
a-b-r-o-w-n,
srinaath and
tonyanziano
| height: 300, | ||
| }); | ||
|
|
||
| updateStatus('Starting server...'); |
There was a problem hiding this comment.
Messages like this should be localized, since the app menu was not localized, I assumed the effort is still going on, please feel free to let me know if things are in place for electron localization and how can I use it.
There was a problem hiding this comment.
Looks like we're not localizing anything in the electron-server directory yet, but we ought to be, with our standard formatMessage calls. Let's open another issue for that and handle this string along with all the others.
There was a problem hiding this comment.
As a side note, the l10n script does look in electron-server already, so no change is needed there. Just get formatMessage around all your strings and you'll be good to go.
There was a problem hiding this comment.
#4120 Here's the issue. I'll take on it myself.
|
This is awesome! 👍👍👍 |
|
Very nice @hatpick |
|
This looks so branded and official. Love it! |
|
@mareekuh I talked to Sangwoo about the "brand family" (Microsoft Azure), and he wasn't sure if Composer falls under that family. What do you think? Should I remove the "Microsoft Azure" wording? |
|
@hatpick let's take this into the nightly and rev the UI if need be. Please move out of Draft when you are ready. Thanks! |
* main: fix: add more missing formatMessage calls (microsoft#4144) feat: electron splash screen (microsoft#4119) feat: Add QnA files to dispatch model in skill manifest (microsoft#3985) fix: check whether operation is under current project folder (microsoft#4078) update localization and add missing "example" string (microsoft#4138) fix: defense invocation of `value.match()` (microsoft#4110) fix: checkReturnType in ExpressionValidation throws unexpected error (microsoft#4112) chore(deps): Bump tree-kill from 1.2.1 to 1.2.2 in /Composer (microsoft#4035) build: fix docker builds in ACR (microsoft#3986) fix: security: downgrade node-forge to 0.9.0 (microsoft#4133) chore: update archiver to fix security warning (microsoft#4116)
* splash screen * Fix css * Fixes logo * Fix blank window * Fixes mac * fix splash screen flashing on linux * Added comments Co-authored-by: Soroush <[email protected]> Co-authored-by: Chris Whitten <[email protected]> Co-authored-by: Geoff Cox (Microsoft) <[email protected]>
8 participants
Description
Adds splash screen to composer.
Task Item
closes #4047
Screenshots
Windows 10
Mac OS (Catalina)
Linux (Ubuntu 20.04 LTS)
