Skip to content

Conversation

@mkrichevsky
Copy link

Moving some tags to constants instead of creating every time should be obvious.
Creation of response status is slightly faster, as we're not casting anymore. More details in benchmark and results

@jkschneider jkschneider added the spring-boot change Change is needed in Spring Boot for this issue label Apr 16, 2018
@jkschneider jkschneider added this to the 1.0.4 milestone Apr 16, 2018
@jkschneider
Copy link
Contributor

@mkrichevsky Could you do me a favor and rebase this against 1.0.x?

@mkrichevsky mkrichevsky changed the base branch from master to 1.0.x April 16, 2018 14:01
@mkrichevsky mkrichevsky changed the base branch from 1.0.x to master April 16, 2018 14:03
@mkrichevsky mkrichevsky changed the base branch from master to 1.0.x April 16, 2018 14:11
@mkrichevsky
Copy link
Author

@jkschneider done :)

@jkschneider jkschneider merged commit 1ae3ad0 into micrometer-metrics:1.0.x Apr 18, 2018
@jkschneider
Copy link
Contributor

jkschneider commented Apr 18, 2018

Interestingly, I think your benchmark demonstrates that there is no real difference between casting the int and Integer.toString(..), but the code is more succinct anyway. Also, that's how it was done in the Spring Boot 2 equivalent class :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

spring-boot change Change is needed in Spring Boot for this issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants