Skip to content

Less object instantiation in WebMvcTags #12894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Less object instantiation in WebMvcTags #12894

wants to merge 1 commit into from

Conversation

jkschneider
Copy link
Contributor

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 18, 2018
@shakuzen
Copy link
Member

@jkschneider master has moved to 2.1.0.BUILD-SNAPSHOT, and I think you want this change targeted at the 2.0.x branch.

@jkschneider jkschneider changed the base branch from master to 2.0.x April 18, 2018 02:55
@jkschneider
Copy link
Contributor Author

Thanks @shakuzen. Getting late here :)

@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 18, 2018
@snicoll snicoll self-assigned this Apr 18, 2018
@snicoll snicoll added this to the 2.0.2 milestone Apr 18, 2018
snicoll pushed a commit that referenced this pull request Apr 18, 2018
@snicoll
Less object instantiation in WebMvcTags
d676147 
See gh-12894
snicoll added a commit that referenced this pull request Apr 18, 2018
@snicoll
Merge pull request #12894 from jkschneider:webmvc-tags-perf
97877c2 
* pr/12894:
  Polish "Less object instantiation in WebMvcTags"
  Less object instantiation in WebMvcTags
@snicoll snicoll closed this in 2b98b11 Apr 18, 2018
@snicoll
Copy link
Member

snicoll commented Apr 18, 2018

@jkschneider thanks. FYI, you've removed some code formatting as part of your PR. Please refrain from doing that, I've added that back in 2b98b11

(unless your IDE does it automatically?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@snicoll snicoll

Labels

type: enhancement A general enhancement

Projects

None yet

Milestone

2.0.2

Development

Successfully merging this pull request may close these issues.

4 participants

@jkschneider @shakuzen @snicoll @spring-projects-issues