Skip to content

better performance of creating web mvc tags #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2018
Merged

better performance of creating web mvc tags #559

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions micrometer-spring-legacy/src/main/java/io/micrometer/spring/web/servlet/WebMvcTags.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ public final class WebMvcTags {

private static final Tag URI_REDIRECTION = Tag.of("uri", "REDIRECTION");

private static final Tag URI_UNKNOWN = Tag.of("uri", "UNKNOWN");

private static final Tag EXCEPTION_NONE = Tag.of("exception", "None");

private static final Tag STATUS_UNKNOWN = Tag.of("status", "UNKNOWN");

private static final Tag METHOD_UNKNOWN = Tag.of("method", "UNKNOWN");

private WebMvcTags() {
}

Expand All @@ -50,9 +58,7 @@ private WebMvcTags() {
* @return the method tag whose value is a capitalized method (e.g. GET).
*/
public static Tag method(@Nullable HttpServletRequest request) {
return request == null ?
Tag.of("method", "UNKNOWN") :
Tag.of("method", request.getMethod());
return request == null ? METHOD_UNKNOWN : Tag.of("method", request.getMethod());
}

/**
Expand All @@ -62,7 +68,7 @@ public static Tag method(@Nullable HttpServletRequest request) {
* @return the status tag derived from the status of the response
*/
public static Tag status(@Nullable HttpServletResponse response) {
return response == null ? Tag.of("status", "UNKNOWN") : Tag.of("status", ((Integer) response.getStatus()).toString());
return response == null ? STATUS_UNKNOWN : Tag.of("status", Integer.toString(response.getStatus()));
}

/**
Expand Down Expand Up @@ -92,7 +98,7 @@ public static Tag uri(@Nullable HttpServletRequest request, @Nullable HttpServle
String pathInfo = getPathInfo(request);
return Tag.of("uri", pathInfo.isEmpty() ? "root" : pathInfo);
}
return Tag.of("uri", "UNKNOWN");
return URI_UNKNOWN;
}

@Nullable
Expand Down Expand Up @@ -125,8 +131,6 @@ private static String getPathInfo(HttpServletRequest request) {
* @return the exception tag derived from the exception
*/
public static Tag exception(@Nullable Throwable exception) {
return exception == null ?
Tag.of("exception", "None") :
Tag.of("exception", exception.getClass().getSimpleName());
return exception == null ? EXCEPTION_NONE : Tag.of("exception", exception.getClass().getSimpleName());
}
}