Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IDF 5 support and deprecate versions 4.1 and 4.2 #176

Merged
merged 12 commits into from
Feb 16, 2023
Merged

Add IDF 5 support and deprecate versions 4.1 and 4.2 #176

merged 12 commits into from
Feb 16, 2023

Conversation

Acuadros95
Copy link
Contributor

@Acuadros95 Acuadros95 commented Feb 15, 2023 •
edited
Loading

Overrides #162

@Acuadros95
Update support for ESP 5
b56ef22 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
C_STANDARD workarround
e5c53b5 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Update docker, nightly and readme
a71ea1a 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Generalice C_VERSION for different IDF versions
c379229 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Remove C_STANDARD from toolchain
b598a7d 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Fix embeddeRTPS
ca813e2 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Fix example
4be35d3 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Fix esp32c3 build
c0ebd13 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Fix macro name
5b48a97 
Signed-off-by: acuadros95 <[email protected]>
@Acuadros95
Copy link
Contributor Author

@pablogs9 We can probably deprecate versions v4.1 and v4.2, as their docker environments use a deprecated cmake version:

CMake 3.15 or higher is required. You are running version 3.13.4

@pablogs9
Copy link
Member

Go ahead

@Acuadros95 Acuadros95 mentioned this pull request Feb 16, 2023
Merged
@Acuadros95 Acuadros95 mentioned this pull request Feb 16, 2023
Closed
@Acuadros95 Acuadros95 changed the title Add IDF 5 support Add IDF 5 support and deprecate versions 4.1 and 4.2 Feb 16, 2023
pablogs9
pablogs9 approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@pablogs9 pablogs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on hardware?

@Acuadros95
Copy link
Contributor Author

Yes, just tested it on a esp32 using the docker approach

@pablogs9
Copy link
Member

In that case, LGTM. We shall notify this internally to announce that we have support for a new major release of IDF

@Acuadros95
Copy link
Contributor Author

@mergify backport humble foxy

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2023 •
edited
Loading

backport humble foxy

✅ Backports have been created

@Acuadros95 Acuadros95 merged commit a71fb63 into main Feb 16, 2023
@Acuadros95 Acuadros95 deleted the feature/esp_v5 branch February 16, 2023 10:42
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
@Acuadros95 @mergify
Add IDF 5 support and deprecate versions 4.1 and 4.2 (#176)
5023b41 
* Update support for ESP 5

Signed-off-by: acuadros95 <[email protected]>

* C_STANDARD workarround

Signed-off-by: acuadros95 <[email protected]>

* Update docker, nightly and readme

Signed-off-by: acuadros95 <[email protected]>

* Generalice C_VERSION for different IDF versions

Signed-off-by: acuadros95 <[email protected]>

* Remove C_STANDARD from toolchain

Signed-off-by: acuadros95 <[email protected]>

* Fix embeddeRTPS

Signed-off-by: acuadros95 <[email protected]>

* Fix example

Signed-off-by: acuadros95 <[email protected]>

* Fix esp32c3 build

Signed-off-by: acuadros95 <[email protected]>

* Fix macro name

Signed-off-by: acuadros95 <[email protected]>

* Deprecate v4.1 and v4.2

Signed-off-by: acuadros95 <[email protected]>

* Deprecate galactic

Signed-off-by: acuadros95 <[email protected]>

* Revert XRCE client temporal branch

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit a71fb63)

# Conflicts:
#	.github/workflows/nightly.yml
This was referenced Feb 16, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 16, 2023
@Acuadros95 @mergify
Add IDF 5 support and deprecate versions 4.1 and 4.2 (#176)
6b00df1 
* Update support for ESP 5

Signed-off-by: acuadros95 <[email protected]>

* C_STANDARD workarround

Signed-off-by: acuadros95 <[email protected]>

* Update docker, nightly and readme

Signed-off-by: acuadros95 <[email protected]>

* Generalice C_VERSION for different IDF versions

Signed-off-by: acuadros95 <[email protected]>

* Remove C_STANDARD from toolchain

Signed-off-by: acuadros95 <[email protected]>

* Fix embeddeRTPS

Signed-off-by: acuadros95 <[email protected]>

* Fix example

Signed-off-by: acuadros95 <[email protected]>

* Fix esp32c3 build

Signed-off-by: acuadros95 <[email protected]>

* Fix macro name

Signed-off-by: acuadros95 <[email protected]>

* Deprecate v4.1 and v4.2

Signed-off-by: acuadros95 <[email protected]>

* Deprecate galactic

Signed-off-by: acuadros95 <[email protected]>

* Revert XRCE client temporal branch

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit a71fb63)

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/nightly.yml
#	CMakeLists.txt
#	docker/Dockerfile
#	esp32_toolchain.cmake.in
#	examples/int32_publisher/main/main.c
#	examples/int32_publisher_embeddedrtps/main/main.c
Acuadros95 added a commit that referenced this pull request Feb 16, 2023
@mergify @Acuadros95
Add IDF 5 support and deprecate versions 4.1 and 4.2 (backport #176) (#…
bd4c425 
…177)

* Add IDF 5 support and deprecate versions 4.1 and 4.2 (#176)

* Update support for ESP 5

Signed-off-by: acuadros95 <[email protected]>

* C_STANDARD workarround

Signed-off-by: acuadros95 <[email protected]>

* Update docker, nightly and readme

Signed-off-by: acuadros95 <[email protected]>

* Generalice C_VERSION for different IDF versions

Signed-off-by: acuadros95 <[email protected]>

* Remove C_STANDARD from toolchain

Signed-off-by: acuadros95 <[email protected]>

* Fix embeddeRTPS

Signed-off-by: acuadros95 <[email protected]>

* Fix example

Signed-off-by: acuadros95 <[email protected]>

* Fix esp32c3 build

Signed-off-by: acuadros95 <[email protected]>

* Fix macro name

Signed-off-by: acuadros95 <[email protected]>

* Deprecate v4.1 and v4.2

Signed-off-by: acuadros95 <[email protected]>

* Deprecate galactic

Signed-off-by: acuadros95 <[email protected]>

* Revert XRCE client temporal branch

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit a71fb63)

# Conflicts:
#	.github/workflows/nightly.yml

* Fix conflicts

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
Co-authored-by: Antonio Cuadros <[email protected]>
Co-authored-by: acuadros95 <[email protected]>
@Acuadros95 Acuadros95 mentioned this pull request Feb 16, 2023
Closed
Acuadros95 added a commit that referenced this pull request Feb 16, 2023
@mergify @Acuadros95
Add IDF 5 support and deprecate versions 4.1 and 4.2 (backport #176) (#…
0d6a175 
…178)

* Add IDF 5 support and deprecate versions 4.1 and 4.2 (#176)

* Update support for ESP 5

Signed-off-by: acuadros95 <[email protected]>

* C_STANDARD workarround

Signed-off-by: acuadros95 <[email protected]>

* Update docker, nightly and readme

Signed-off-by: acuadros95 <[email protected]>

* Generalice C_VERSION for different IDF versions

Signed-off-by: acuadros95 <[email protected]>

* Remove C_STANDARD from toolchain

Signed-off-by: acuadros95 <[email protected]>

* Fix embeddeRTPS

Signed-off-by: acuadros95 <[email protected]>

* Fix example

Signed-off-by: acuadros95 <[email protected]>

* Fix esp32c3 build

Signed-off-by: acuadros95 <[email protected]>

* Fix macro name

Signed-off-by: acuadros95 <[email protected]>

* Deprecate v4.1 and v4.2

Signed-off-by: acuadros95 <[email protected]>

* Deprecate galactic

Signed-off-by: acuadros95 <[email protected]>

* Revert XRCE client temporal branch

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
(cherry picked from commit a71fb63)

# Conflicts:
#	.github/workflows/ci.yml
#	.github/workflows/nightly.yml
#	CMakeLists.txt
#	docker/Dockerfile
#	esp32_toolchain.cmake.in
#	examples/int32_publisher/main/main.c
#	examples/int32_publisher_embeddedrtps/main/main.c

* Fix conflicts

Signed-off-by: acuadros95 <[email protected]>

* Remove embeddedRTPS from foxy

Signed-off-by: acuadros95 <[email protected]>

* Add missing cmake def

Signed-off-by: acuadros95 <[email protected]>

---------

Signed-off-by: acuadros95 <[email protected]>
Co-authored-by: Antonio Cuadros <[email protected]>
Co-authored-by: acuadros95 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogs9 pablogs9 pablogs9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Acuadros95 @pablogs9