Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make micro ros epsidf work with IDF 5 #162

Closed
wants to merge 7 commits into from

Conversation

sebastianohl
Copy link

This pull request enables building micro ros with ESP IDE 5

To test is, a new Dockerfile referencing to IDF 5 is also included.

Changes:

  • Adding a few includes
  • fixing a bad format in int32_publisher (may also be needed with the other examples, but i was only testing with this one)
  • Pull request "Update CMakeLists.txt # 160" ist also included.

Tested with EPS32S3 with included docker container and also with platform.io ESP IDF 5.1.1 platform

@pablogs9
Copy link
Member

Hello, @sebastianohl thanks a lot for this contribution!!

Can you add this to the CI and also to the README.md ?

@sebastianohl
Copy link
Author

hope that its complete now. let's see what to CI says...

@sebastianohl
Copy link
Author

finally the ci is working. this build system is not very handsome for integrating new frameworks...

@pablogs9
Copy link
Member

@sebastianohl feel free to propose any improvement to the build system

@CasCard
Copy link

CasCard commented Jan 23, 2023

please merge this

@anslex
Copy link

anslex commented Jan 23, 2023

@CasCard does it compile successfully? Which hardware if yes?
I have checked recently and there was an issue with types (linux amd64, mac m1 arm64) probably due to freertos includes. Haven't explored further

@ALUIS97
Copy link

ALUIS97 commented Jan 28, 2023

sorry @CasCard in which esp hardware have you tested this ????

@Acuadros95
Copy link
Contributor

There was an issue with the C standard version of some of micro-ROS packages, which has been solved on our side.
We are including your update with some fixes on this PR: #176

Closing, feel free to provide any feedback if you test our implementation with the v5 version.

@Acuadros95 Acuadros95 closed this Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants