Bump the Golang version to 1.16

[fmuyassarov]

Bump the Golang version to 1.16

[fmuyassarov]

/cc @maelk
/cc @stbenjam

[kashifest]

/lgtm

[metal3-io-bot]

@kashifest: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[smoshiur1237]

/lgtm

[metal3-io-bot]

@smoshiur1237: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[maelk]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [maelk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fmuyassarov]

/cc @russellb

[fmuyassarov]

/hold until all the local tests are verified and passed

[fmuyassarov]

/hold cancel
Local tests seem to be fine with govet, golint, unit test and etc. The only change that will be needed is in BMO to update the gp.sum. Actually, kubebuilder version was also updated after running /hack/generate.sh, but I we can decide if we need that update or not.

[fmuyassarov]

/hold

[fmuyassarov]

/hold cancel
Local tests seem to be fine with govet, golint, unit test and etc. The only change that will be needed is in BMO to update the gp.sum. Actually, kubebuilder version was also updated after running /hack/generate.sh, but I we can decide if we need that update or not.

Apparently I wasn't running local CI checks. I tested all the CI checks with Makefile targets, and tests are passing.

fmuyassarov@est:~/est/baremetal-operator$ make lint
bin/golangci-lint run
fmuyassarov@est:~/est/baremetal-operator$ make sec
bin/golangci-lint run
fmuyassarov@est:~/est/baremetal-operator$ make vet
bin/golangci-lint run
mafmuyassarov@est:~/est/baremetal-operator$ make fmt
bin/golangci-lint run
fmuyassarov@est:~/est/baremetal-operator$ make unit
go test ./...  -coverprofile cover.out
?       github.com/metal3-io/baremetal-operator [no test files]
ok      github.com/metal3-io/baremetal-operator/apis/metal3.io/v1alpha1 0.006s  coverage: 13.4% of statements
?       github.com/metal3-io/baremetal-operator/cmd/get-hardware-details    [no test files]
?       github.com/metal3-io/baremetal-operator/cmd/make-bm-worker  [no test files]
ok      github.com/metal3-io/baremetal-operator/cmd/make-bm-worker/templates    0.003s  coverage: 100.0% of statements
?       github.com/metal3-io/baremetal-operator/cmd/make-virt-host  [no test files]
ok      github.com/metal3-io/baremetal-operator/controllers/metal3.io   0.044s  coverage: 78.1% of statements
ok      github.com/metal3-io/baremetal-operator/pkg/bmc 0.019s  coverage: 68.3% of statements
?       github.com/metal3-io/baremetal-operator/pkg/hardware    [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/provisioner [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/provisioner/demo    [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/provisioner/empty   [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/provisioner/fixture [no test files]
ok      github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic  0.125s  coverage: 70.7% of statements
ok      github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic/clients  0.019s  coverage: 20.6% of statements
ok      github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic/devicehints  0.004s  coverage: 96.0% of statements
ok      github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic/hardwaredetails  0.004s  coverage: 60.8% of statements
?       github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic/testbmc  [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/provisioner/ironic/testserver   [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/utils   [no test files]
?       github.com/metal3-io/baremetal-operator/pkg/version [no test files]
fmuyassarov@est:~/est/baremetal-operator$ make generate
bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
fmuyassarov@est:~/est/baremetal-operator$ make mod
go mod tidy
go mod verify

/hold cancel

[maelk]

/lgtm

[metal3-io-bot]

@fmuyassarov: Updated the config configmap in namespace default at cluster default using the following files:

• key config.yaml using file prow/config/config.yaml

Details

In response to this:

Bump the Golang version to 1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.