Skip to content

🏃 Bump the Golang version to 1.16#23

Merged
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:bump-golang-to-1.16/feruz
Mar 2, 2021
Merged

🏃 Bump the Golang version to 1.16#23
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:bump-golang-to-1.16/feruz

Conversation

@fmuyassarov
Copy link
Copy Markdown
Member

What this PR does / why we need it:
Bump the Golang version to 1.16

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 19, 2021
@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2021
@fmuyassarov
Copy link
Copy Markdown
Member Author

/hold until metal3-io/project-infra#172 gets merged
/test-integration

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 19, 2021
@fmuyassarov
Copy link
Copy Markdown
Member Author

/hold cancel
since metal3-io/project-infra#172 is merged now.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2021
@fmuyassarov fmuyassarov force-pushed the bump-golang-to-1.16/feruz branch from 5956b64 to ec6e5bc Compare February 27, 2021 23:13
@fmuyassarov
Copy link
Copy Markdown
Member Author

/test-integration

1 similar comment
@fmuyassarov
Copy link
Copy Markdown
Member Author

/test-integration

@fmuyassarov
Copy link
Copy Markdown
Member Author

/cc @furkatgofurov7

Copy link
Copy Markdown
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fmuyassarov fmuyassarov force-pushed the bump-golang-to-1.16/feruz branch from ec6e5bc to 0eade9a Compare March 1, 2021 18:39
@fmuyassarov
Copy link
Copy Markdown
Member Author

Seems you are missing some more places that need to be updated, see below:

* https://github.com/metal3-io/ip-address-manager/blob/master/Makefile#L322

* https://github.com/metal3-io/ip-address-manager/blob/master/hack/ensure-go.sh#L34

* https://github.com/metal3-io/ip-address-manager/blob/master/hack/tools/go.mod#L3

@furkatgofurov7 thanks. Fixed.

@fmuyassarov
Copy link
Copy Markdown
Member Author

/test-integration

@fmuyassarov
Copy link
Copy Markdown
Member Author

/cc @kashifest

@metal3-io-bot metal3-io-bot requested a review from kashifest March 2, 2021 12:23
Bump the Golang version to 1.16
@fmuyassarov fmuyassarov force-pushed the bump-golang-to-1.16/feruz branch from 0eade9a to 1d694bd Compare March 2, 2021 14:16
Copy link
Copy Markdown
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2021
@fmuyassarov
Copy link
Copy Markdown
Member Author

/test-integration

@metal3-io-bot metal3-io-bot merged commit f27bca4 into metal3-io:master Mar 2, 2021
@fmuyassarov fmuyassarov deleted the bump-golang-to-1.16/feruz branch May 3, 2021 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants