Skip to content
This repository was archived by the owner on Jan 5, 2023. It is now read-only.

Bump the Golang version to 1.16#61

Merged
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:bump-golang-to-1.16/feruz
Mar 23, 2021
Merged

Bump the Golang version to 1.16#61
metal3-io-bot merged 1 commit into
metal3-io:masterfrom
Nordix:bump-golang-to-1.16/feruz

Conversation

@fmuyassarov
Copy link
Copy Markdown
Member

Bump the Golang version to 1.16
/hold until metal3-io/project-infra#172 gets merged
/cc @maelk

@metal3-io-bot metal3-io-bot requested a review from maelk February 21, 2021 10:07
@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 21, 2021
@maelk
Copy link
Copy Markdown
Member

maelk commented Feb 27, 2021

/approve
but this should get the green light from some of the main developers of this project

@metal3-io-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fmuyassarov, maelk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2021
@fmuyassarov
Copy link
Copy Markdown
Member Author

/hold cancel
since metal3-io/project-infra#172 is merged now.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2021
Bump the Golang version to 1.16
@fmuyassarov fmuyassarov force-pushed the bump-golang-to-1.16/feruz branch from 3b8e38f to a665b7e Compare February 27, 2021 23:15
@fmuyassarov
Copy link
Copy Markdown
Member Author

/cc @dhellmann
/cc @digambar15

@sumitjadhav1
Copy link
Copy Markdown

/cc @dhellmann
/cc @digambar15
Please take a look, this is waiting for lgtm label

@digambar15 digambar15 added the lgtm Indicates that a PR is ready to be merged. label Mar 23, 2021
@digambar15
Copy link
Copy Markdown
Contributor

Looks Good.

@metal3-io-bot metal3-io-bot merged commit 5b6b02f into metal3-io:master Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants