Correctly run controller-gen for new apis module#888
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom May 24, 2021
Merged
Correctly run controller-gen for new apis module#888metal3-io-bot merged 1 commit intometal3-io:masterfrom
metal3-io-bot merged 1 commit intometal3-io:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
approved
Because apis is in a separate go module now, we need to run controller-gen on this module not on the main one. We don't want to make the apis module depend on controller-gen, because the whole point is to minimise dependencies. However, we can't use "go run" to across modules because we can't switch modules between build and run. Accordingly, split the build and run phases so that we can keep the version information in the main module but run in the apis module. Fixes metal3-io#875
Member
|
This looks good to me. I can close #877 in favor of this. |
Member
Author
|
/test-integration |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #875