Also run controller-gen on the controller directory to get rbac#892
Also run controller-gen on the controller directory to get rbac#892metal3-io-bot merged 1 commit intometal3-io:masterfrom asalkeld:fix-controller-gen
Conversation
metal3-io-bot
added
the
size/XS
| .PHONY: generate | ||
| generate: tools/bin/controller-gen ## Generate code | ||
| cd apis; ../$< object:headerFile="../hack/boilerplate.go.txt" paths="./..." | ||
| $< object:headerFile="hack/boilerplate.go.txt" paths="./..." |
There was a problem hiding this comment.
Out of curiousity, do we need both generate and manifests, or might just manifests suffice (at least for now)?
There was a problem hiding this comment.
this is to just make sure that if we add something in another dir, it's not going confuse the hell out of someone for hours.
|
/lgtm |
|
/test-integration |
|
@kashifest this is a follow-up to fix a mistake I made in #888, could you take a look? |
|
/lgtm |
|
Thanks @kashifest. I updated the description so we should be good to go. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
5 participants
The RBAC manifests are built from the controller (not api) code, so we have to run the
make manifestscommands at least on both the API module and the main module.