Add api generation in make generate

[kashifest]

This PR adds api generation in generate Make target

Fixes #875

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kashifest
To complete the pull request process, please assign maelk after the PR has been reviewed.
You can assign the PR to them by writing /assign @maelk in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kashifest]

/test-integration
/cc @dhellmann

[andfasano]

I think that this could be a reasonable approach until we'll keep the two go.mod separated. Probably not something that will scale well, but for now seems enough.

/lgtm

[s3rj1k]

@andfasano But this brings new dep for API sigs.k8s.io/controller-tools v0.5.0
And it is only needed for code-generating, effectively this makes separate go.mod useless, external projects would need to import a lot of unneeded dependencies just like it was before separate go.mod.

Also note that version of controller tools are different
https://github.com/metal3-io/baremetal-operator/blob/master/go.mod#L19

v0.5.0 VS v0.4.1 in core go.mod

I do not think that this is acceptable, controller-tools version should be same across whole repo

[kashifest]

Also note that version of controller tools are different
https://github.com/metal3-io/baremetal-operator/blob/master/go.mod#L19

v0.5.0 VS v0.4.1 in core go.mod

I do not think that this is acceptable, controller-tools version should be same across whole repo

I can change that

[metal3-io-bot]

New changes are detected. LGTM label has been removed.

[kashifest]

/test-integration
@s3rj1k @andfasano PTAL again. I think we can take it in to fix apis generation until we have an alternative.

[zaneb]

AFAIK everything we need to generate is always in the apis directory, isn't it? I think we could remove this line (and the equivalent below).
That would at least solve the problem of trying to keep the controller-gen version the same in two different go.mod files.

[kashifest]

makes sense. @s3rj1k WDYT?

[s3rj1k]

https://github.com/metal3-io/baremetal-operator/pull/888/files

[zaneb]

I opened #888 to do this without having to add dependencies to the apis module, so closing in favour of that per Kashif's comment #888 (comment).
/close

[metal3-io-bot]

@zaneb: Closed this PR.

Details

In response to this:

I opened #888 to do this without having to add dependencies to the apis module, so closing in favour of that per Kashif's comment #888 (comment).
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.