Skip to content

start adding unit tests for Ironic.InspectHardware#649

Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom
andfasano:unit-test-inspect-hardware
Oct 9, 2020
Merged

start adding unit tests for Ironic.InspectHardware#649
metal3-io-bot merged 1 commit intometal3-io:masterfrom
andfasano:unit-test-inspect-hardware

Conversation

@andfasano
Copy link
Copy Markdown
Member

@andfasano andfasano commented Sep 24, 2020

Increasing test coverage for Ironic provisioner

@metal3-io-bot metal3-io-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 24, 2020
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Sep 24, 2020

I would like to freeze non-essential changes for a few days to try to land #650 without having to rebase it, because rebasing will mean redoing the work from scratch.

/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2020
dhellmann
dhellmann reviewed Sep 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dhellmann dhellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread pkg/provisioner/ironic/testserver/server.go
Comment thread pkg/provisioner/ironic/testserver/server.go Outdated
Comment thread pkg/provisioner/ironic/inspecthardware_test.go
}).
WithIntrospectionData(nodeUUID, introspection.Data{
Inventory: introspection.InventoryType{
Hostname: "node-0",
Copy link
Copy Markdown
Member

@dhellmann dhellmann Sep 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does the name come from?

Copy link
Copy Markdown
Member Author

@andfasano andfasano Sep 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just followed the Ironic Inspector API, ie https://docs.openstack.org/ironic-inspector/5.1.0/http-api.html#get-introspection-data, to have roughly a one-to-one relationship

@asalkeld asalkeld mentioned this pull request Sep 25, 2020
Merged
@andfasano andfasano changed the title [WIP] start adding unit tests for Ironic.InspectHardware start adding unit tests for Ironic.InspectHardware Sep 25, 2020
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2020
@andfasano andfasano force-pushed the unit-test-inspect-hardware branch from 6787038 to c2ebc23 Compare September 25, 2020 10:10
@andfasano
Copy link
Copy Markdown
Member Author

andfasano commented Sep 28, 2020

/test generate

@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 1, 2020

#655 has merged

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2020
@andfasano andfasano force-pushed the unit-test-inspect-hardware branch 2 times, most recently from 4845dfc to 3507906 Compare October 5, 2020 14:13
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 6, 2020

/approve
/test-integration

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 6, 2020
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 6, 2020

/retest

1 similar comment
@andfasano
Copy link
Copy Markdown
Member Author

andfasano commented Oct 6, 2020

/retest

@andfasano
Copy link
Copy Markdown
Member Author

andfasano commented Oct 7, 2020

/test-integration

@asalkeld
Copy link
Copy Markdown
Contributor

asalkeld commented Oct 7, 2020

/lgtm

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 7, 2020

@asalkeld: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andfasano andfasano mentioned this pull request Oct 8, 2020
Merged
@andfasano andfasano force-pushed the unit-test-inspect-hardware branch from b15feca to 2f52643 Compare October 8, 2020 13:36
@andfasano
Copy link
Copy Markdown
Member Author

andfasano commented Oct 8, 2020

/test-integration

@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 9, 2020

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 9, 2020
@metal3-io-bot metal3-io-bot merged commit 4f5bdfe into metal3-io:master Oct 9, 2020
@dhellmann dhellmann mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhellmann dhellmann dhellmann left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andfasano @dhellmann @metal3-io-bot @asalkeld