Skip to content

Unit tests for ironic.{Adopt,PowerOn,PowerOff,Provision,Deprovision}#653

Merged
metal3-io-bot merged 5 commits intometal3-io:masterfrom
asalkeld:unit-test-adopt
Oct 22, 2020
Merged

Unit tests for ironic.{Adopt,PowerOn,PowerOff,Provision,Deprovision}#653
metal3-io-bot merged 5 commits intometal3-io:masterfrom
asalkeld:unit-test-adopt

Conversation

@asalkeld
Copy link
Copy Markdown
Contributor

@asalkeld asalkeld commented Sep 25, 2020

this builds on top of #649

@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Sep 25, 2020

Hi @asalkeld. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

andfasano
andfasano reviewed Sep 25, 2020
View reviewed changes
Comment thread pkg/provisioner/ironic/findhost_test.go Outdated
Comment thread pkg/provisioner/ironic/findhost_test.go Outdated
@zaneb
Copy link
Copy Markdown
Member

zaneb commented Sep 25, 2020

/ok-to-test

@metal3-io-bot metal3-io-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 25, 2020
@asalkeld
Copy link
Copy Markdown
Contributor Author

asalkeld commented Sep 27, 2020

/test generate

@asalkeld asalkeld changed the title Unit tests for ironic.Adopt() Unit tests for ironic.{Adopt,PowerOn,PowerOff} Sep 28, 2020
@metal3-io-bot metal3-io-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 1, 2020
@asalkeld asalkeld requested a review from andfasano October 7, 2020 06:56
andfasano
andfasano reviewed Oct 7, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@andfasano andfasano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine to me. Once #649 will get merged, probably you could squash your commits

@asalkeld asalkeld changed the title Unit tests for ironic.{Adopt,PowerOn,PowerOff} Unit tests for ironic.{Adopt,PowerOn,PowerOff,Provision,Deprovision} Oct 9, 2020
@andfasano
Copy link
Copy Markdown
Member

andfasano commented Oct 13, 2020

/test-integration

@asalkeld
Add unit tests for ironic.Adopt()
1951941
@asalkeld
Add PowerOn unit tests
94972d1
@asalkeld
Add PowerOff unit tests
90bd932 
Note: hard powerOff case is not tested as it requires returning different
results from the same handler and the mockServer doesn't support that just
yet.
@asalkeld
Add Provision unit tests
caef589
@asalkeld
Add Deprovision unit tests
4ef885d
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 21, 2020

/approve

@metal3-io-bot
Copy link
Copy Markdown
Contributor

metal3-io-bot commented Oct 21, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asalkeld, dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2020
@dhellmann
Copy link
Copy Markdown
Member

dhellmann commented Oct 22, 2020

/test-integration
/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2020
@metal3-io-bot metal3-io-bot merged commit cbbdb22 into metal3-io:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andfasano andfasano andfasano left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asalkeld @metal3-io-bot @zaneb @andfasano @dhellmann