start adding unit tests for Ironic.UpdateHardwareState#673
Merged
metal3-io-bot merged 1 commit intometal3-io:masterfrom Oct 26, 2020
Merged
Conversation
Member
Author
|
/hold waiting merge of #649 |
metal3-io-bot
added
do-not-merge/hold
andfasano
force-pushed
the
unit-test-update-hardware-state
branch
3 times, most recently
from
380a76b to
7266cec
Compare
Member
Author
|
/test govet |
Member
Author
|
/test-integration |
1 similar comment
Member
Author
|
/test-integration |
Member
Author
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
dhellmann
reviewed
Oct 14, 2020
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/metal3-io/baremetal-operator/pkg/bmc" |
Member
There was a problem hiding this comment.
I think we want this block of imports at the bottom. I'm not sure why the linter didn't flag this. Maybe @asalkeld can help with that?
dhellmann
requested changes
Oct 14, 2020
andfasano
force-pushed
the
unit-test-update-hardware-state
branch
from
7266cec to
1f4a03f
Compare
Member
Author
|
/test-integration |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, dhellmann The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
approved
andfasano
force-pushed
the
unit-test-update-hardware-state
branch
from
1f4a03f to
9ec8eb9
Compare
Member
Author
|
/test govet |
andfasano
force-pushed
the
unit-test-update-hardware-state
branch
from
9ec8eb9 to
c4f8ab1
Compare
Member
Author
|
/hold fixing a test case |
metal3-io-bot
added
the
do-not-merge/hold
andfasano
force-pushed
the
unit-test-update-hardware-state
branch
from
c4f8ab1 to
1d8d8da
Compare
Member
Author
|
/test-integration |
Member
|
/lgtm I'll leave it to you to cancel the hold, in case you're still working on something. |
Member
Author
|
/hold cancel |
metal3-io-bot
removed
the
do-not-merge/hold
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increasing test coverage for Ironic provisioner