Skip to content

Add idrac-redfish url type#419

Closed
juliakreger wants to merge 2 commits intometal3-io:masterfrom
juliakreger:idrac-redfish-ipxe
Closed

Add idrac-redfish url type#419
juliakreger wants to merge 2 commits intometal3-io:masterfrom
juliakreger:idrac-redfish-ipxe

Conversation

@juliakreger
Copy link
Copy Markdown
Member

The idrac BMCs have partiular handling of boot mode as configuration
change requests which need to be honored only at power state changes
as opposed to immediately, because this can conflict and over-write
existing configuration jobs.

While we shouldn't be in this state without more advanced bmc
features being leveraged, it is best to use the vendor supported
hardware type and interfaces for using redfish with their hardware.

This boot interface defaults to using iPXE, as opposed to virtual
media. A separate idrac specific redfish virtual media interface
already existed in the baremetal-operator.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2020
Comment thread pkg/bmc/redfish.go Outdated
Comment thread docs/api.md
Comment thread docs/api.md Outdated
Comment thread docs/api.md Outdated
Comment thread docs/api.md Outdated
Comment thread docs/api.md Outdated
Comment thread pkg/bmc/redfish.go Outdated
Comment thread pkg/bmc/redfish.go
@juliakreger juliakreger force-pushed the idrac-redfish-ipxe branch 5 times, most recently from a7acab3 to 051f6e6 Compare February 6, 2020 22:30
Comment thread pkg/bmc/redfish.go Outdated
Comment thread pkg/bmc/access_test.go Outdated
Comment thread pkg/bmc/redfish.go Outdated
@juliakreger juliakreger force-pushed the idrac-redfish-ipxe branch 2 times, most recently from 89ba1a3 to b2a9fd4 Compare February 12, 2020 18:26
The idrac BMCs have partiular handling of boot mode as configuration
change requests which need to be honored only at power state changes
as opposed to immediately, because this can conflict and over-write
existing configuration jobs.

While we shouldn't be in this state without more advanced bmc
features being leveraged, it is best to use the vendor supported
hardware type and interfaces for using redfish with their hardware.

This boot interface defaults to using iPXE, as opposed to virtual
media. A separate idrac specific redfish virtual media interface
already existed in the baremetal-operator.
@metal3-io-bot
Copy link
Copy Markdown
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@zaneb
Copy link
Copy Markdown
Member

zaneb commented May 12, 2020

/remove-lifecycle stale
/approve

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliakreger, zaneb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2020
@metal3-io-bot
Copy link
Copy Markdown
Contributor

@juliakreger: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
gofmt 7954192 link /test gofmt
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dhellmann
Copy link
Copy Markdown
Member

@juliakreger it looks like this needs to be run through go fmt. Do you want to do that and update the PR?

@dhellmann
Copy link
Copy Markdown
Member

This will need to be rebased.

@dhellmann
Copy link
Copy Markdown
Member

I think #633 replaces this.

@dhellmann dhellmann closed this Sep 16, 2020
dtantsur pushed a commit to dtantsur/baremetal-operator that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants