Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/api.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ mainly, but not only, provisioning details.
and the port is optional, if using the default one (623).
* Dell iDRAC
* `idrac://` (or `idrac+http://` to disable TLS).
Comment thread
juliakreger marked this conversation as resolved.
* `idrac-redfish://` may be used to manage iDRAC controller with the
Redfish protocol over HTTPS. The URL must also contain a path to
the Redfish API system endpoint.
`idrac-redfish://myhost.example/redfish/v1/Systems/System.Embedded.1`
* `idrac-virtualmedia://` to use virtual media instead of PXE
for attaching the provisioning image to the host.
* Fujitsu iRMC
Expand Down
24 changes: 24 additions & 0 deletions pkg/bmc/access_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,18 @@ func TestStaticDriverInfo(t *testing.T) {
vendor: "",
},

{
Scenario: "idrac redfish",
input: "idrac-redfish://192.168.122.1",
needsMac: true,
driver: "idrac",
boot: "ipxe",
management: "idrac-redfish",
power: "idrac-redfish",
raid: "no-raid",
vendor: "no-vendor",
},

{
Scenario: "ilo5 virtual media",
input: "ilo5-virtualmedia://192.168.122.1",
Expand Down Expand Up @@ -644,6 +656,18 @@ func TestDriverInfo(t *testing.T) {
},
},

{
Scenario: "idrac redfish",
input: "idrac-redfish://192.168.122.1/foo/bar",
expects: map[string]interface{}{
"redfish_address": "https://192.168.122.1",
"redfish_system_id": "/foo/bar",
"redfish_password": "",
"redfish_username": "",
"redfish_verify_ca": false,
},
},

{
Scenario: "idrac virtual media",
input: "idrac-virtualmedia://192.168.122.1/foo/bar",
Expand Down
37 changes: 37 additions & 0 deletions pkg/bmc/redfish.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ func init() {
registerFactory("redfish-virtualmedia", newRedfishVirtualMediaAccessDetails)
registerFactory("ilo5-virtualmedia", newRedfishVirtualMediaAccessDetails)
registerFactory("idrac-virtualmedia", newRedfishiDracVirtualMediaAccessDetails)
registerFactory("idrac-redfish", newRedfishiDracAccessDetails)
}

func redfishDetails(parsedURL *url.URL, disableCertificateVerification bool) *redfishAccessDetails {
Expand Down Expand Up @@ -39,6 +40,12 @@ func newRedfishiDracVirtualMediaAccessDetails(parsedURL *url.URL, disableCertifi
}, nil
}

func newRedfishiDracAccessDetails(parsedURL *url.URL, disableCertificateVerification bool) (AccessDetails, error) {
return &redfishiDracAccessDetails{
*redfishDetails(parsedURL, disableCertificateVerification),
}, nil
}

type redfishAccessDetails struct {
bmcType string
host string
Expand All @@ -50,6 +57,10 @@ type redfishVirtualMediaAccessDetails struct {
redfishAccessDetails
}

type redfishiDracAccessDetails struct {
redfishAccessDetails
}

type redfishiDracVirtualMediaAccessDetails struct {
redfishAccessDetails
}
Expand Down Expand Up @@ -127,6 +138,32 @@ func (a *redfishAccessDetails) VendorInterface() string {
return ""
}

// iDrac Redfish Overrides

func (a *redfishiDracAccessDetails) Driver() string {
return "idrac"
}

func (a *redfishiDracAccessDetails) BootInterface() string {
return "ipxe"
}

func (a *redfishiDracAccessDetails) ManagementInterface() string {
return "idrac-redfish"
}

func (a *redfishiDracAccessDetails) PowerInterface() string {
return "idrac-redfish"
}

func (a *redfishiDracAccessDetails) RAIDInterface() string {
return "no-raid"
}

func (a *redfishiDracAccessDetails) VendorInterface() string {
return "no-vendor"
Comment thread
juliakreger marked this conversation as resolved.
}

// Virtual Media Overrides

func (a *redfishVirtualMediaAccessDetails) BootInterface() string {
Expand Down