Improve error message when using oneOf validation. Fixes #254
#272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbalsas
suggested changes
Oct 10, 2017
| @@ -185,6 +186,15 @@ function composeError(error, name, context) { | |||
| } | |||
|
|
|||
| /** | |||
| * Composes an error message for Conifg.oneOf validator. | |||
There was a problem hiding this comment.
Possible typo: Conifg.oneOf -> Config.oneOf
|
We don't currently test the contents of any error messages, we only test that an error is returned or not given the input. We can add tests for this, but if we do we should probably add tests for the other use cases as well. |
|
Sounds good, just the typo, then 👍 |
|
Hey @Robert-Frampton i was reviewing that tests and i've started a discussion here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.