Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message on validators #279

Closed
diegonvs opened this issue Oct 16, 2017 · 3 comments
Closed

Improve error message on validators #279

diegonvs opened this issue Oct 16, 2017 · 3 comments
Labels
enhancement
Milestone
2.14.1

Comments

@diegonvs
Copy link
Contributor

After @Robert-Frampton changes of oneOf on #272 i was reviewing some test cases on clay-components and i’ve saw that shapeOf and arrayOf error messages keeps returning simple messages like:

Warning: Error: Warning: Invalid state passed to 'icon'. Expected object with a specific shape. Passed to 'ClayButton’.

I suggest enhance some text messages on validators to user get the attr with problem more faster.

What do you think, folks?
@robframpton
Copy link

We can definitely look into improving those error messages as well.

@jbalsas jbalsas added this to the 2.14.1 milestone Nov 2, 2017
@diegonvs
Copy link
Contributor Author

#297

@robframpton
Copy link

robframpton commented Nov 28, 2017 •
edited
Loading

Fixed by #315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
2.14.1
Development

No branches or pull requests
3 participants
@jbalsas @robframpton @diegonvs