You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm reviewing the tests on validators and i’ve saw a problem that the usage of assert.ok() is probably not adequate in our tests, maybe we can use assert.isTrue().
If validators.any() function is broken, these tests will pass no matter what that function returns (unless it returns false - which we never return). I suggest we change from assert.ok to assert.isTrue to verify cases that passes/corrects.
The text was updated successfully, but these errors were encountered:
I'm reviewing the tests on validators and i’ve saw a problem that the usage of assert.ok() is probably not adequate in our tests, maybe we can use assert.isTrue().
Taking this hypothesis:
If
validators.any()
function is broken, these tests will pass no matter what that function returns (unless it returnsfalse
- which we never return). I suggest we change from assert.ok to assert.isTrue to verify cases that passes/corrects.The text was updated successfully, but these errors were encountered: