Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename intercept.js #236

Merged
merged 2 commits into from
May 12, 2017
Merged

Rename intercept.js #236

merged 2 commits into from
May 12, 2017

Conversation

jbalsas
Copy link
Contributor

@jbalsas jbalsas commented May 12, 2017

This PR addresses the issue described in #228 with blocker extensions and intercept.js by renaming it to IncrementalDomAop.js, making it consistent at the same time with SoyAop

Copy link

@brunobasto brunobasto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@robframpton robframpton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robframpton robframpton merged commit 3038c55 into master May 12, 2017
@eduardolundgren
Copy link
Contributor

Camel case files are for classes. This one has no class inside, therefore it needs to be lowercased. Could you guys update? Sorry for catching that later.

@robframpton
Copy link

#237

@jbalsas jbalsas deleted the rename_intercept.js branch October 10, 2017 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants