Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename IncrementalDomAop.js to incremental-dom-aop.js #237

Merged
merged 1 commit into from
May 16, 2017

Conversation

robframpton
Copy link

No description provided.

@eduardolundgren
Copy link
Contributor

LGTM

@jbalsas jbalsas merged commit 9f68c6b into metal:master May 16, 2017
@jbalsas
Copy link
Contributor

jbalsas commented May 16, 2017

Merged!

Hey @eduardolundgren, I copied this pattern from SoyAop, so I guess we should rename that one as well...

@jbalsas
Copy link
Contributor

jbalsas commented May 16, 2017

Actually, at least Config and iDOMHelpers seem to also have the wrong capitalization.

I guess we could just wait to rename them until we plan a major release, so unless you guys feel strongly about it, I'll leave these and SoyAop as they are and enforce this rule from now on :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants