Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename metal-incremental-dom/src/intercept #228

Closed
yuchi opened this issue Apr 19, 2017 · 3 comments
Closed

Rename metal-incremental-dom/src/intercept #228

yuchi opened this issue Apr 19, 2017 · 3 comments

Comments

@yuchi
Copy link
Contributor

yuchi commented Apr 19, 2017

Ok, I know I’ll sound silly but…

schermata 2017-04-19 alle 11 17 38

What is going on here is that my ad blocker (uBlock) is considering intercept as a bad keyword.
It is even worse when paired with combo loading: the whole combo is “blocked by client”.
@robframpton
Copy link

@jbalsas can we look into this? Various people have ran into this very issue, and it's probably worth while since uBlock is a popular tool.

Plus we won't get as many misleading bug reports in Portal :)

@jbalsas
Copy link
Contributor

jbalsas commented May 12, 2017

Hey @Robert-Frampton, @yuchi, I've sent #236 renaming intercept.js to IncrementalDomAop.js

@jbalsas jbalsas mentioned this issue May 12, 2017
Merged
@jbalsas
Copy link
Contributor

jbalsas commented Jun 15, 2017

This was fixed by 502880a and released in 2.11.0

@jbalsas jbalsas closed this as completed Jun 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yuchi @jbalsas @robframpton