refactor: update dagre-d3-es to v7.0.14#7357
Conversation
The order of the arguments for `graph.setEdge()` in `createGraphWithElements` is incorrect. I've updated the call to instead use an object to make it a bit more clear, since the order is a bit unusual. This function isn't actually used anywhere in our code, which is why this is only a `refactor:` commit, not a `fix:` commit. But from talking to @knsv, it sounds like this is going to be used by future layout algorithms, so we should keep this file. But, this unblocks upgrading to `dagre-d3-es` `7.0.14`, which has updated types for this.
This release includes some basic TypeScript types, which makes our life easier! See: https://github.com/tbo47/dagre-es/releases/tag/7.0.14
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7357 +/- ##
==========================================
- Coverage 3.59% 3.58% -0.01%
==========================================
Files 474 474
Lines 47514 47529 +15
Branches 740 740
==========================================
Hits 1706 1706
- Misses 45808 45823 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📑 Summary
This release includes some TypeScript types for
graphlib, which makes our life easier!See: https://github.com/tbo47/dagre-es/releases/tag/7.0.14
See: tbo47/dagre-es#61
See: tbo47/dagre-es#60
This should unblock #7274
📏 Design Decisions
The broken types caught an issue in the
createGraphWithElementsfunction inpackages/mermaid/src/rendering-util/createGraph.ts, where we were callinggraph.setEdgewith the arguments in the wrong order. See https://github.com/dagrejs/graphlib/wikiThis function isn't actually used anywhere in our code, which is why this PR is only a
refactorPR and why I haven't added a changeset to this PR.But according to @knsv, we are going to use the file in the future (it seems like it was accidentally committed from a different WIP branch), so it's best to keep it in to avoid merge conflicts.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.