Skip to content

Add graphlib/alg and graphlib/data JSDoc TypeScript types#61

Merged
tbo47 merged 4 commits intotbo47:mainfrom
aloisklink:fix/improve-more-graphlib-types
Dec 3, 2025
Merged

Add graphlib/alg and graphlib/data JSDoc TypeScript types#61
tbo47 merged 4 commits intotbo47:mainfrom
aloisklink:fix/improve-more-graphlib-types

Conversation

@aloisklink
Copy link
Collaborator

@aloisklink aloisklink commented Nov 23, 2025

On top of #60, this PR also adds JSDoc types to the files in graphlib/alg, graphlib/data, and graphlib/json.js.

I've mostly copied over the documentation from the graphlib wiki, making some minor changes to match the JSDoc/TSDoc tags.

See: https://github.com/dagrejs/graphlib/wiki/API-Reference

CI is failing right now, since it depends on the changes in #60.

@aloisklink aloisklink force-pushed the fix/improve-more-graphlib-types branch from 43bf55b to d7c52f2 Compare November 23, 2025 15:55
@tbo47
Copy link
Owner

tbo47 commented Dec 3, 2025

@aloisklink Do you mind rebasing and force push? To see if the test passes/

@aloisklink aloisklink force-pushed the fix/improve-more-graphlib-types branch from d7c52f2 to 69fbd75 Compare December 3, 2025 16:00
@aloisklink
Copy link
Collaborator Author

Fixed! Thanks @tbo47.

I also noticed one tiny issue, I forgot to update one of the old cpettitt/graphlib links to the current https://github.com/dagrejs/graphlib page, so I've fixed that too.

The cpettitt GitHub username has been taken over by a white-hat hacker, so even though it might safely redirect now to https://github.com/dagrejs/graphlib, maybe it won't in the future (https://github.com/cpettitt/dagre-d3 no longer redirects).

@tbo47 tbo47 merged commit 6baeb67 into tbo47:main Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants