fix(northlight): BREAKING CHANGE slideFade hideDisplay default state #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set hideDisplay default state to closes: DEV-10342
✅ Deploy Preview for luminous-medovik-367cf4 canceled.
|
|
@ilija- This is a breaking change, make sure to write that in the commit and also check in webapp that all the slideFades work as expected with hideDisplay set to true |
Will do ! |
ilija-
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set hideDisplay default state to
truecloses: DEV-10342
If prop 'hideDisplay' is not passed with value true. The slideFade will prevent users from clicking area under the slideFade even if the slide is closed. I think that there are not many cases when this behaviour is desired and that it's easy to miss passing this prop to the component.