Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(northlight): BREAKING CHANGE slideFade hideDisplay default state #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −2
Open

fix(northlight): BREAKING CHANGE slideFade hideDisplay default state #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion framework/lib/components/transitions/slide-fade.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ export const SlideFade = ({
duration = null,
in: show = false,
disableFocus = true,
hideDisplay = false,
hideDisplay = true,
direction = 'bottom',
offset: delta = defaultOffset,
offsetX: deltaX = 0,
Expand Down
3 changes: 2 additions & 1 deletion framework/lib/components/transitions/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@ export interface FadeProps extends ChakraFadeProps {
exitDuration?: DurationType
/** Makes the element not focusable when not visible */
disableFocus?: boolean
/** Will remove the component from DOM tree if in is false */
/** Will remove the component from DOM tree if in is false. By Default this is set to [true]
* to prevent users from clicking area under the slideFade even if the slide is closed. */
hideDisplay?: boolean
enterDelay?: number
exitDelay?: number
Expand Down