fix(northlight): slideFade hideDisplay default state

Set hideDisplay default state to closes: DEV-10342
mediatool · Dec 27, 2023 · 257c70c · 257c70c
1 parent a50cb7b
commit 257c70c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/framework/lib/components/transitions/slide-fade.tsx b/framework/lib/components/transitions/slide-fade.tsx
@@ -12,7 +12,7 @@ export const SlideFade = ({
   duration = null,
   in: show = false,
   disableFocus = true,
-  hideDisplay = false,
+  hideDisplay = true,
   direction = 'bottom',
   offset: delta = defaultOffset,
   offsetX: deltaX = 0,

diff --git a/framework/lib/components/transitions/types.ts b/framework/lib/components/transitions/types.ts
@@ -19,7 +19,8 @@ export interface FadeProps extends ChakraFadeProps {
   exitDuration?: DurationType
   /** Makes the element not focusable when not visible */
   disableFocus?: boolean
-  /** Will remove the component from DOM tree if in is false */
+  /** Will remove the component from DOM tree if in is false. By Default this is set to [true]
+   * to prevent users from clicking area under the slideFade even if the slide is closed. */
   hideDisplay?: boolean
   enterDelay?: number
   exitDelay?: number