Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement policy for reviewing/merging mdn content PR's #1098

Closed
escattone opened this issue Aug 19, 2020 · 2 comments · Fixed by mdn/content#143
Closed

Implement policy for reviewing/merging mdn content PR's #1098

escattone opened this issue Aug 19, 2020 · 2 comments · Fixed by mdn/content#143
Assignees
Milestone

Comments

@escattone
Copy link
Contributor

Implement the policy for handling mdn/mdn-content repo's PR's decided in #1097.

@escattone escattone added this to the Yari1 milestone Aug 19, 2020
@escattone escattone changed the title Implement policy for reviewing/merging mdn/mdn-content PR's Implement policy for reviewing/merging mdn content PR's Aug 19, 2020
@peterbe
Copy link
Contributor

peterbe commented Nov 2, 2020

Here's a start:

  1. If the PR has merge conflicts, it's on the author to resolve and merge in main to her branch and push that updated branch.
  2. If CI fails, it won't be merged. The editor and author will share the responsibility to find out why CI failed.
  3. Don't use git rebase on a branch that has an associated PR created.
  4. The editor has the right to close PRs that are deemed to span too many unrelated topics if the PR isn't phrased as a general solution that explains the breadth of the change.
  5. If it's a non-trivial edit, there should exist an issue and that issue's ID (e.g. #123) should be mentioned in the PR description.
  6. Don't reopen a PR that an editor has closed.

@escattone escattone self-assigned this Nov 16, 2020
@escattone
Copy link
Contributor Author

@peterbe I'll add your items to the content contribution guide (README.md), and then I'm going to close this, since we've got the CODEOWNERS file in place as well a contribution guide. We can work from there in terms of tweaking the contribution guide going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants