You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
escattone
changed the title
Implement policy for reviewing/merging mdn/mdn-content PR's
Implement policy for reviewing/merging mdn content PR's
Aug 19, 2020
If the PR has merge conflicts, it's on the author to resolve and merge in main to her branch and push that updated branch.
If CI fails, it won't be merged. The editor and author will share the responsibility to find out why CI failed.
Don't use git rebase on a branch that has an associated PR created.
The editor has the right to close PRs that are deemed to span too many unrelated topics if the PR isn't phrased as a general solution that explains the breadth of the change.
If it's a non-trivial edit, there should exist an issue and that issue's ID (e.g. #123) should be mentioned in the PR description.
@peterbe I'll add your items to the content contribution guide (README.md), and then I'm going to close this, since we've got the CODEOWNERS file in place as well a contribution guide. We can work from there in terms of tweaking the contribution guide going forward.
Implement the policy for handling mdn/mdn-content repo's PR's decided in #1097.
The text was updated successfully, but these errors were encountered: