-
Notifications
You must be signed in to change notification settings - Fork 22.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial CODEOWNERS file #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My first concern is that I don't know what it means when it says @peterbe @escattone
. Does it mean, it triggers 2 review requests?
Whenever that happens, I'm always confused but I assume it means "This PR needs a review from me AND the other names listed"
The remedy to that is that the review request goes to a GitHub team instead. E.g. core-yari-dev
which means that the review request only needs a review from 1 person in the team.
(by the way, I sent an invite to @fiji-flo to that team)
What I'd prefer is that we set up 1 new team for all the content. It'll just have Chris a first and single member today, but it feels more right.
I'm not sure how to review this PR itself. Part of me wants to take the idea of teams seriously rather than a list of usernames. But we also have to "just do it" and learn as we go instead of waiting for perfection.
But I really do think we should help readers of this file to explain what it does. At least an executive summary and/or a link to the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Peter's suggestion of using GitHub teams is probably a good one. We use individual users on BCD and it's a little fussy when someone can't or doesn't want to review something (they have to individually opt out).
One concrete suggestion in a line comment. Thanks!
Thanks for the review @peterbe and @ddbeck! Here's what I did based on your feedback:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you, @escattone!
Just FYI, I spoke with @chrisdavidmills about this during our meeting this morning, and he's OK to start with this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I must admit, I struggle to fully form an opinion on this.
If all it does is create some default review requests, then the only sane thing might be to just get started.
Also, it seems we don't need to nail this perfectly as we'll still be able to use our existing access rights to merge whatever needs to be merged anyway.
Let's get this started, so I'm going to merge this. We can iterate from here. |
This is an initial step towards mdn/yari#1098. It shows what we can do with a
CODEOWNERS
file. We can build on this going forward.By the way, for this repo I've enabled the
Require review from Code Owners
feature, which will kick-in once we merge this PR.