Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on policy for reviewing/merging mdn content repo PR's #1097

Closed
escattone opened this issue Aug 19, 2020 · 2 comments
Closed

Decide on policy for reviewing/merging mdn content repo PR's #1097

escattone opened this issue Aug 19, 2020 · 2 comments
Assignees
Milestone

Comments

@escattone
Copy link
Contributor

Need to determine a policy for mdn/mdn-content repo's PR's given that we no longer have the content team. For example, perhaps we should simply auto-merge a PR if the linters/tests pass?

@escattone escattone added this to the Yari1 milestone Aug 19, 2020
@escattone escattone changed the title Decide on policy for reviewing/merging mdn/mdn-content PR's Decide on policy for reviewing/merging mdn content repo PR's Aug 19, 2020
@peterbe
Copy link
Contributor

peterbe commented Aug 20, 2020

We don't really have linters yet. ...on the content.

At the moment, we disable flaw checking in PR Builds because there's sooo many flaws. That'll be significantly reduced once we have done a manual mass-cleanup using the fixable flaws.
But there's still a large number of flaws that are not fixable. For example, use of remote images that 404. If someone wants to fix a typo in a paragraph far away from the <img> tag, should that block her PR?

I do wonder if we should let @chrisdavidmills own this and give him time to perhaps formulate a policy after the Yari1 launch. Then he can make it up based on what actually happens.

I for one would love it if there's a document to point to. One that says some basic writing rules (e.g. no swear words, American English spelling, no aggressive tone, consistency over perfection) and also basic stuff such as one PR per topic, don't rebase your own PRs, merge in upstream master yourself if there are conflicts, etc.

@escattone escattone self-assigned this Nov 16, 2020
@escattone
Copy link
Contributor Author

We've got the CODEOWNERS file in place as well a contribution guide. We can work from there in terms of tweaking the contribution guide going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants